27 files inspected, 157 offenses detected:

 

Rakefile - 1 offense

Line #26convention: Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
task :default => [:foodcritic, :rubocop, :knife, :dist]

 

Vagrantfile - 4 offenses

Line #22convention: Style/CommentAnnotation: Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
  # TODO - hacky replacement of https://www.vagrantup.com/docs/provisioning/chef_solo.html#recipe_url
Line #26convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
  config.vm.provision "shell",
Line #35convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
  config.vm.provider "virtualbox" do |v|
Line #42warning: Lint/UselessAssignment: Useless assignment to variable - run_list.
    run_list = ['alfresco::default']

 

packer-ami.rb - 77 offenses

Line #3convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    "alfresco_version" => "{{env `ALFRESCO_VERSION`}}"
Line #3convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
    "alfresco_version" => "{{env `ALFRESCO_VERSION`}}"
Line #3convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    "alfresco_version" => "{{env `ALFRESCO_VERSION`}}"
Line #7convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
      "clean-temp-folders" => {
Line #8convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "type"=> "shell",
Line #8convention: Style/SpaceAroundOperators: Surrounding space missing for operator =>.
        "type"=> "shell",
Line #8convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "type"=> "shell",
Line #9convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "inline" => [
Line #11convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /tmp/packer-chef-solo",
Line #12convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /etc/chef/cookbooks",
Line #13convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /etc/chef/databags"
Line #13convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline array.
          "sudo rm -rf /etc/chef/databags"
Line #14convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
        ]
Line #15convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
      }
Line #18convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
      "chef" => {
Line #19convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "json"=> {
Line #19convention: Style/SpaceAroundOperators: Surrounding space missing for operator =>.
        "json"=> {
Line #20convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "name" => "img-trials",
Line #20convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "name" => "img-trials",
Line #21convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "alfresco" => {
Line #22convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
            "version" => "{{user `alfresco_version`}}"
Line #22convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
            "version" => "{{user `alfresco_version`}}"
Line #22convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
            "version" => "{{user `alfresco_version`}}"
Line #24convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "hosts" => {
Line #25convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
            "host_list" => {
Line #26convention: Style/CommentAnnotation: Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
              # TODO - This is temporary, until there's a better solution
Line #27convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
              "minislaven1 minislaven1.alfresco.pri" => "10.80.217.144"
Line #27convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
              "minislaven1 minislaven1.alfresco.pri" => "10.80.217.144"
Line #27convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
              "minislaven1 minislaven1.alfresco.pri" => "10.80.217.144"
Line #28convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
            }
Line #32convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "snort" => {
Line #33convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
            "start_snort" => false
Line #33convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
            "start_snort" => false
Line #35convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "chef_client" => {
Line #36convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
            "source_cookbook_path" => "/tmp/packer-chef-solo/cookbooks-0",
Line #36convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
            "source_cookbook_path" => "/tmp/packer-chef-solo/cookbooks-0",
Line #37convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
            "source_data_bag_path" => "/tmp/packer-chef-solo/data_bags"
Line #37convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
            "source_data_bag_path" => "/tmp/packer-chef-solo/data_bags"
Line #37convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
            "source_data_bag_path" => "/tmp/packer-chef-solo/data_bags"
Line #38convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
          }
Line #40convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "run_list" => [ "img-trials::default" ]
Line #40convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
        "run_list" => [ "img-trials::default" ]
Line #40convention: Style/SpaceInsideBrackets: Space inside square brackets detected.
        "run_list" => [ "img-trials::default" ]
Line #40convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "run_list" => [ "img-trials::default" ]
Line #40convention: Style/SpaceInsideBrackets: Space inside square brackets detected.
        "run_list" => [ "img-trials::default" ]
Line #41convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
      }
Line #44convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
      "yum-clean-all" => {
Line #45convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "type"=> "shell",
Line #45convention: Style/SpaceAroundOperators: Surrounding space missing for operator =>.
        "type"=> "shell",
Line #45convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "type"=> "shell",
Line #46convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "inline" => [
Line #47convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo yum -y clean all",
Line #48convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /root/.m2",
Line #49convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /usr/share/tomca*/work/*",
Line #50convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /usr/share/tomca*/temp/*",
Line #51convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /etc/chef/nodes/*",
Line #52convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /etc/yum.repos.d/alfresco.repo",
Line #53convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /etc/cron.hourly/0yum-hourly.cron",
Line #54convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /etc/cron.daily/0yum-daily.cron",
Line #55convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /etc/cron.hourly/0anacron",
Line #56convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /etc/anacrontab",
Line #57convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo find /var/log -type f -delete",
Line #58convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo find /tmp -type f -delete",
Line #59convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline array.
          "echo 'Printing DF\n' ; sudo df -h"
Line #60convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
        ]
Line #61convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
      }
Line #62convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
    }
Line #66convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    "launch_block_device_mappings" => [
Line #67convention: Style/IndentArray: Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is.
    { ...
Line #68convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
      "device_name" => "/dev/sda1",
Line #68convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
      "device_name" => "/dev/sda1",
Line #69convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
      "volume_size" => 60,
Line #70convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
      "volume_type" => "gp2",
Line #70convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
      "volume_type" => "gp2",
Line #71convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
      "delete_on_termination" => true
Line #71convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
      "delete_on_termination" => true
Line #72convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
    }]

 

packer-vagrant.rb - 70 offenses

Line #4convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
      "clean-temp-folder" => {
Line #5convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "type"=> "shell",
Line #5convention: Style/SpaceAroundOperators: Surrounding space missing for operator =>.
        "type"=> "shell",
Line #5convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "type"=> "shell",
Line #6convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "inline" => [
Line #7convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -Rf /tmp/*"
Line #7convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline array.
          "sudo rm -Rf /tmp/*"
Line #8convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
        ]
Line #9convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
      }
Line #12convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
      "chef" => {
Line #13convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "json"=> {
Line #13convention: Style/SpaceAroundOperators: Surrounding space missing for operator =>.
        "json"=> {
Line #14convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "name"=> "img-trials-test",
Line #14convention: Style/SpaceAroundOperators: Surrounding space missing for operator =>.
          "name"=> "img-trials-test",
Line #14convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "name"=> "img-trials-test",
Line #15convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "image" => {
Line #17convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
            "root_alias" => "not_set"
Line #17convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
            "root_alias" => "not_set"
Line #17convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
            "root_alias" => "not_set"
Line #19convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "hosts" => {
Line #20convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
            "host_list" => {
Line #21convention: Style/CommentAnnotation: Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
              # TODO - not needed anymore, test it
Line #23convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
            }
Line #25convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "chef_client" => {
Line #26convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
            "source_cookbook_path" => "/tmp/packer-chef-solo/cookbooks-0",
Line #26convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
            "source_cookbook_path" => "/tmp/packer-chef-solo/cookbooks-0",
Line #27convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
            "source_data_bag_path" => "/tmp/packer-chef-solo/databags"
Line #27convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
            "source_data_bag_path" => "/tmp/packer-chef-solo/databags"
Line #27convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
            "source_data_bag_path" => "/tmp/packer-chef-solo/databags"
Line #28convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
          }
Line #30convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "run_list" => [ "img-trials::default" ]
Line #30convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
        "run_list" => [ "img-trials::default" ]
Line #30convention: Style/SpaceInsideBrackets: Space inside square brackets detected.
        "run_list" => [ "img-trials::default" ]
Line #30convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "run_list" => [ "img-trials::default" ]
Line #30convention: Style/SpaceInsideBrackets: Space inside square brackets detected.
        "run_list" => [ "img-trials::default" ]
Line #31convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
      }
Line #34convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
      "vagrant-insecure-ssh-key" => {
Line #35convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "type" => "shell",
Line #35convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "type" => "shell",
Line #36convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "inline" => [
Line #37convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "mkdir -p /home/vagrant/.ssh",
Line #38convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "chmod 0700 /home/vagrant/.ssh",
Line #39convention: Style/CommentAnnotation: Annotation keywords like TODO should be all upper case, followed by a colon, and a space, then a note describing the problem.
          # TODO - Why this? Next one shouldn't be needed, as delivered by img-basic::_packages
Line #41convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo yum install -y wget bzip2",
Line #42convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "wget --no-check-certificate https://raw.github.com/mitchellh/vagrant/master/keys/vagrant.pub -O /home/vagrant/.ssh/authorized_keys",
Line #43convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "chmod 0600 /home/vagrant/.ssh/authorized_keys",
Line #44convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "chown -R vagrant /home/vagrant/.ssh"
Line #44convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline array.
          "chown -R vagrant /home/vagrant/.ssh"
Line #45convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
        ]
Line #46convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
      }
Line #49convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
      "erase-data" => {
Line #50convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "type"=> "shell",
Line #50convention: Style/SpaceAroundOperators: Surrounding space missing for operator =>.
        "type"=> "shell",
Line #50convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "type"=> "shell",
Line #51convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
        "inline" => [
Line #52convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -f /var/log/*",
Line #53convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /tmp/*",
Line #54convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /etc/chef/nodes/*",
Line #55convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo yum -y clean all",
Line #56convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /root/.m2",
Line #57convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /usr/share/tomca*/work/*",
Line #58convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /usr/share/tomca*/temp/*",
Line #59convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /usr/share/tomca*/logs/*",
Line #60convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /usr/share/tomcat/*.log",
Line #61convention: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
          "sudo rm -rf /usr/share/tomcat/*.log.*",
Line #62convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline array.
          "echo 'Printing DF\n' ; sudo df -h"
Line #63convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
        ]
Line #64convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
      }
Line #65convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
    }
Line #73convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
    'only' => ['vbox-iso']

 

recipes/alfresco.rb - 1 offense

Line #6convention: Style/BlockDelimiters: Avoid using {...} for multi-line blocks.
  packages.each { |package|

 

recipes/run-chef-client.rb - 3 offenses

Line #26convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
      'url' => internal_rules_url
Line #30convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline hash.
      'url' => internal_emerging_rules_url
Line #31convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline array.
    }

 

recipes/snort-config.rb - 1 offense

Line #6convention: Style/TrailingCommaInLiteral: Put a comma after the last item of a multiline array.
  { 'path' => '/etc/snort/emerging.rules.tar.gz' }